Ross MacArthur comments

Results 61 comments of


                                            Ross MacArthur

Pass anyhow::Error where impl Error is expected

@hniksic the reason is that the implementation would be incoherent with the following two existing implementations: 1. `impl From for anyhow::Error where E: std::error::Error + Send + Sync + 'static`...

local plugin failed to find any files matching

You can specify which files will be matched. Either using the `use` field on a plugin. Or adjusting the global `match` field. See the documentation here: - https://sheldon.cli.rs/Configuration.html#use - https://sheldon.cli.rs/Configuration.html#match

Don't use tests that actually make network calls

Yeah I disabled these tests for now https://github.com/rossmacarthur/sheldon/commit/86bbfe1204d7a58e6a5308e2d61c295ecf1790bf

Sheldon should follow XDG Base Directory spec even if environment variables are not defined

I agree it would be better to respect XDG and people can always override this by setting `SHELDON_CONFIG_DIR` and `SHELDON_DATA_DIR`.

Support SOCKS5 proxies

Hi, what happens if you set the global config ` git config --global core.gitProxy`?

sheldon lock --update fails if github is configured to use ssh

@lburgazzoli are you using an `ssh-agent`? Currently sheldon only supports authentication over ssh when there is an `ssh-agent` present. As far as I understand SSH with github always requires authentication...

Customizing Variables

I think this is a great idea, I would be happy to accept a pull request for this change. I think the variable should be set before the plugin is...

zdiff3 stops sheldon lock installing plugins

Hi @jonnybarnes, thanks for the report. I am able to replicate. It looks like this is due to the the fact that we vendor libgit2 in sheldon and the currently...

Not rendering the colors

I have the same issue in iTerm2

Not rendering the colors

Perhaps I need to make changes to my iTerm2 settings? The background seems particularly to be the problem here.