Benjamin Ross

Add fx.From Annotation to allow passing an implementation type as an interface parameter

9

The most common pattern I hear about to use in `go` is accept interfaces and return structs. The newest `fx` framework addition `fx.As(...)` makes following this paradigm much more intuitive...

adds fx.From annotation

2

Adds fx.From annotation to allow injecting struct ptr types for interface dependencies which they implement. This should address issue https://github.com/uber-go/fx/issues/878

Can `fx.Private` be scoped as a top-level `fx.Option` instead of a `var`

3

**Is your feature request related to a problem? Please describe.** I'd like to be able to continue the scoping story started with `fx.Private` but make it a top-level `fx.Option` that...

fx.Private yields incorrect fx.Dotgraph visualization

2

**Describe the bug** The `fx.Dotgraph` displayed when visualizing the dependency graph is incorrect when using the new `fx.Private` variable. **To Reproduce** For the following code it prints as expected "foo\nbar"...

Pipeline Query Language (querying metrics) Feature Request

3

Not sure if this is the right place to request a feature, but I am interested to find an open source database to add capabilities in querying metrics with an...

Inconsistent Bucket Sizing Overflow Behavior on Different Architectures

1

Please see https://github.com/uber-go/tally/issues/264 likely same issue on the java side.

Allow mockable/predictable now()

6

Its hard to test out programs that rely on time for example: ``` now().Sub(StartTime) >= 40*duration("24h") ``` Would it be possible to allow a testing option for `now()` to give...

The bucket creating methods such as [this one](https://github.com/uber-go/tally/blob/master/histogram.go#L348) should return an error or panic if the bucket sizes overflow. Overflow behavior is inconsistent between cpu architectures: For inputs like ```...