Rosa Gutierrez
Rosa Gutierrez
I run into this as well! @zelivans what do you think of adding also a test for this? This is the one I had added myself before realising there was...
Thanks a lot for the review, @mikel! I'll get these changes implemented this week, I hope.
Implemented the changes requested 😊
@tmedford I'm sorry, I'm not sure I follow. Harshly handled errors don't cause a blacklisted connection, gracefully handled errors do: https://github.com/taskrabbit/makara/blob/7f6e9d0c1a8be6ff73b630f2092894a6556ff046/lib/makara/error_handler.rb#L26-L36
@tmedford because it's an error, and it's raised as such. What you see in your logs comes from here: ```ruby def harshly(e) ::Makara::Logging::Logger.log("Harshly handling: #{e}\n#{e.backtrace.join("\n\t")}") raise e end ``` But...
I was thinking lately about this as well, but also because it'd be useful to have the opposite too. That is, a way of forcing some queries to go always...
@artkirienko this is working fine for me. For example: ```ruby >> User.last # Uses replica [replica] User Load (5.5ms) SELECT `users`.* FROM `users` ORDER BY `users`.`id` DESC LIMIT 1 >>...
@bleonard yes! That seems totally fine 👍 Happy to do the change if you want!
> Or maybe @jamby1100 wants to make a PR and you review. Oh, yes, even better! 👍
Hey @hjleochen, sorry for the delay on this one; I didn't realise it had been reopened. Could you let me know how you're enqueuing `FutureInsJob`? Is it via `FutureInsJob.perorm_later`? And...