rory malcolm
rory malcolm
Is there any update on this issue? How can I build a Dockerfile from a built NextJS app without copying the next binary?
@r0mant, @benarent what's the process for requesting a review on this?
Hey @grobinson-grafana , thanks for getting back promptly - as above, have started work in that PR!
> Looks good, a couple comments. It also needs docs [here](https://github.com/prometheus/alertmanager/blob/main/docs/configuration.md?plain=1#L749) and [here](https://github.com/prometheus/alertmanager/blob/main/docs/configuration.md?plain=1#L1195) 👍 All done - I think? 🙏
> You still have some failing tests I'm afraid https://github.com/prometheus/alertmanager/actions/runs/14933150149/job/41982648209?pr=4372 > > ``` > --- FAIL: TestIncidentIORetry (0.01s) > incidentio_test.go:48: > Error Trace: /__w/alertmanager/alertmanager/notify/incidentio/incidentio_test.go:48 > Error: Received unexpected error: >...
Hey @grobinson-grafana - just confirming this is good to go?