Rootul P

DO NOT MERGE draft PR for exploration purposes

specs: identify inconsistencies in implementation

9

Discussed offline with @evan-forbes and we need to do a pass of existing specs, identify inconsistencies, fix them, and then migrate specs to individual repos. ## Inconsistencies - https://github.com/celestiaorg/celestia-specs/issues/211 -...

## Context https://github.com/celestiaorg/celestia-specs/pull/217#discussion_r973721077 ## Problem The specs contain `SignedTransaction*` that aren't Celestia specific like `SignedTransactionDataCreateValidator`. It seems like Celestia defers to the Cosmos SDK definitions of these transactions so we...

specs: increase number of reserved bytes to two

1

## Problem https://github.com/celestiaorg/celestia-app/pull/850 increased the number of reserved bytes from 1 to 2: https://github.com/celestiaorg/celestia-app/blob/45353941dc365630b42b096fb587044ab6fa36f2/pkg/appconsts/appconsts.go#L28-L30 so the specs are now inaccurate https://github.com/celestiaorg/celestia-app/blob/2cc65da4e2663b4ba94e8be7861fe81f2be5d09c/specs/src/specs/consensus.md?plain=1#L58 ## Proposal 1. Update the constant from `1` to...

## Context https://celestiaorg.github.io/celestia-specs/latest/specs/data_structures.html#share ## Problem There is an inconsistency between the specs and current implementation: the first share of a message includes a length delimiter. See https://github.com/celestiaorg/celestia-app/blob/main/pkg/shares/split_sparse_shares.go#L25

We should update https://celestiaorg.github.io/celestia-specs/latest/specs/data_structures.html#share to describe the universal share encoding schema. See [this ADR](https://github.com/celestiaorg/celestia-app/pull/660) for more details.

Upgrade to Go 1.19

3

## Problem This repo currently uses Go 1.18 ([ref](https://github.com/celestiaorg/celestia-app/blob/d53f66b67946d20af5a24487c2f79da4ebb1b171/go.mod#L3)). Go [1.19](https://go.dev/blog/go1.19) was released. The celestia-node repo has already upgraded to Go 1.19. For developers that are working across multiple Celestia...

## Context https://github.com/celestiaorg/celestia-app/pull/842#pullrequestreview-1139027323 ## Problem We have package-specific Godocs in [shares/doc.go](https://github.com/celestiaorg/celestia-app/blob/c9dce391bc360bb5f068f43d4eb1681a9f35b710/pkg/shares/doc.go). However, some contributors prefer to read README.md files over godocs. As a convenience to contributors, we may want to...

Replace usage of `TIA` with `CLS` in downstream repos

2

## Context After we have a celestia-app release that includes https://github.com/celestiaorg/celestia-app/pull/859 we'll want to upgrade downstream repos and replace usage of `TIA` with `CLS` Ref: https://github.com/search?p=1&q=org%3Acelestiaorg+tia&type=Code ## Repos - [...

All shares in a reserved namespace belong to one share sequence

3

### Problem https://github.com/celestiaorg/celestia-app/issues/659 introduced an info byte that contains a sequence start indicator. The indicator must be `1` for the first share in a reserved namespace and `0` for continuation...