Rootul P

Results 242 issues of Rootul P

## Summary [Keynote Intro to ABCI ++ by Callum Waters](https://youtu.be/UuDrSpo_Q-I?t=570) describes that ABCI++ will support immediate agreement (also known as immediate execution). ## Context Currently celestia-core uses delayed agreement. ##...

T:tendermint
T:investigate
C:consensus
T:adr

## Summary This repo could benefit from a guide on how to cut a new release ## Problem Definition Current release process is to ask @evan-forbes or @liamsi to cut...

C:documentation

## Context In celestia-app 0.7.0, there is a breaking change to the [shares.Split](https://github.com/celestiaorg/celestia-app/blob/c9dce391bc360bb5f068f43d4eb1681a9f35b710/pkg/shares/share_splitting.go#L22-L25). This issue is a follow-up TODO from https://github.com/celestiaorg/celestia-node/pull/1147 ## Problem Unit tests in share/availability/light/availability_test.go currently set `useShareIndexes=false`...

area:core_and_app
testing

### Problem https://github.com/celestiaorg/celestia-app/issues/659 introduced an info byte which contains a share version. Currently a block proposer could construct a share with a version that hasn't yet been defined (ex. share...

share encoding

Closes https://github.com/celestiaorg/celestia-app/issues/729 [Rendered](https://github.com/celestiaorg/celestia-app/blob/486bb9918d23d7a9ff5afe3094a6703996eac812/specs/src/specs/data_structures.md#share)

specs

## Description Previously, there were functions named `*PayForData` that actually dealt with `WirePayForData`s. Since a PayForData != WirePayForData, I found the previous naming confusing. This change renames functions to more...

breaking

## Description 1. Rename `TestProcessMessage` to `TestProcessWirePayForData` so that the test name matches the function under test 2. Move the test to `wirepayfordata_test.go` because it is applicable to WirePayForData not...

T: chore

Closes https://github.com/celestiaorg/celestia-app/issues/873 Closes https://github.com/informalsystems/audit-celestia/issues/20

### Summary of Bug We're observing instances where a fuzz test has uncovered a bug. See CI run: https://github.com/celestiaorg/celestia-app/actions/runs/3318414871/jobs/5482354309#step:6:149 ### Version https://github.com/celestiaorg/celestia-app/commit/26eeca4d35588991ccec7dcaf2defd4d63854e82 and `main` (?) ### Steps to Reproduce @evan-forbes...

bug

## Context https://github.com/informalsystems/audit-celestia/issues/20#issuecomment-1278899785 ## Problem The sparse share splitter struct contains the field `count` which needs to be updated when modifying shares in the sparse share splitter. https://github.com/celestiaorg/celestia-app/blob/3598fe28772ed1ad55a0bc0b76d222828d35960f/pkg/shares/split_sparse_shares.go#L17 ## Proposal...

good first issue
T:enhancement