Pat Tullmann

Results 57 comments of Pat Tullmann

To be clear, in this case you are not worried about arbitrary sub-processes forked by CI right? Just Zig-spawned builders/tester processes that are all running Zig code (and are all...

I can see how Zig's error mapping has created confusion in your case. "EINVAL" here can mean the socket is an invalid state ("not listening for connections"), or some of...

LGTM. Great to see improvements to the fmt error cases. They can be annoying to map back the actual code. I see `test/cases/compile_errors/std.fmt_error_for_unused_arguments.zig` has a related test case, may be...

Yeah, there are some open glibc linking issues with Zig. I thought the current git builds had fixes for these string problems (I could definitely see there being additional problems,...

Can you try with a recent Zig build? I'm pretty sure there are fixes (like #17489) that are not in v0.11.0. That said, the fact that you're seeing `__isoc23_sscanf` when...

CI tests are passing. The two CI failures seem to be `native-native-musl` failures: > run test std-x86_64-linux-none-Debug-selfhosted-no-lld: error: Illegal instruction at address 0x81febbe run test std-x86_64-linux-none-Debug-selfhosted-no-lld: error: while executing test...

I think this is good to go then. I'll see if I can add some tests of some sort that cover different glibc versions.

(I don't mean to steal @lifthrasiir's PRs, which are the bulk of this stack, so I'm happy to donate my patches to his stack if that keeps the attributions correct.)

I found `test/link/glibc_compat/build.zig`, which I expanded with some more tests. I compile some simple code (calls fstat, reallocarray, getauxval, and atexit) against a bunch of different glibc versions and makes...

Oh, and my suggested tests are just covering the "positive" cases of glibc symbols being linked correctly. I don't test things like older versions *not* having newer symbols (e.g., `reallocarray`...