Rony Fadel comments

Results 20 comments of


                                            Rony Fadel

Object.fromEntries is not a function

+1, I'm seeing this as well on node v10.18.0

no implicit conversion of nil into String when trying to use upload_to_app_store with osx

I keep hitting this for my macOS builds: ``` platform :mac do desc "Push a new release build to the App Store" lane :release do build_app(workspace: "VidCap.xcworkspace", scheme: "VidCap", catalyst_platform:...

100% crash when calling whisper_init_from_file_with_params with Address Sanitizer enabled (Xcode, ggml-large-v2) on both use_gpu={0,1}

@jianhuihi this is a different issue stop commenting here please

100% crash when calling whisper_init_from_file_with_params with Address Sanitizer enabled (Xcode, ggml-large-v2) on both use_gpu={0,1}

It doesn't crash if I run `./bin/main -m ../models/ggml-large-v2.bin -f ../samples/gb0.wav --no-gpu` but it does in Xcode. Hmmm 🤔.

The prints are all false

Can you give more info please? As is, the info provided is pretty mediocre.

Shorter segments?

There's been discussions in openai/whisper where you could skew the model to output shorter segments by tweaking `max_text_token_logprob`: https://github.com/openai/whisper/discussions/435#discussioncomment-4010615 Is something similar with the codebase in faster-whisper?

Shorter segments?

I just saw the addition of `length_penalty` today. How should it be used? Its default value is set to 1.

Shorter segments?

@guillaumekln from my testing, I've also had great results using the `token_timestamps` flag [here](https://github.com/ggerganov/whisper.cpp/blob/0d229163bbea769c7a3e0e500e45850c9a6e2e42/whisper.h#L276) Tbh, I don't know what CTranslate2 does to the underlying model, and if such capabilities are...

timestamps are not as accurate as other Whisper implementations

cc @Vaibhavs10

PhotosPicer can't be opened in the closure

Please provide a code example or a working project