ronanh

Results 12 comments of ronanh

Yeah, had the same thoughts. This whole thing started as a hack since I couldn't find what I needed in other libraries. Then realised that it would not make much...

Thanks for the benchmarks. Can there be memory alignment issues if make unsafe conversion from ints to []byte? Since we don't control the allocation of compressed buffers I don't think...

Fine for checking that input is aligned. What I don't get is how do you ensure that the input you supply is properly aligned. Does allocating a multiple of 8...

> I just came across this nice library and was wondering what's the best way to write the compressed slice to a byte buffer. [binary package](https://pkg.go.dev/encoding/binary#ByteOrder) provides a way to...

I'm running the benchmarks, will check the speed. Will try to find time to review this PR later today, quite a lot of changes! Take some rest, I cannot keep...

@pascaldekloe I'm having mixed feelings with this one. There's quite a lot of efforts into it, and it improves readability. But there's also a lot of stuff and it's difficult...

I have pushed a branch [input-arrays](https://github.com/ronanh/intcomp/tree/input-arrays) where I have included those changes: input arrays, changing order of parameters, remove panic in switch. Will run benchmarks on it to compare.

Another approach that might be performant would be to assign the whole array in one go from a big literal in the generate code...

> https://pkg.go.dev/github.com/pascaldekloe/[email protected]/pack64 Looks promising. The speed will be good. I see that you chose to disable compression for more that 42 bits, not enough compression gains? Do you plan to...

Thanks for the advice. I've started some work for this 'fixed boundaries' frames thing, and it adds more complexity that I had thought at first, so you're probably right. I...