ronan-lashermes
ronan-lashermes
> I appreciate the effort that you put into this, but to me much of this may help if you try to get into it but feels like overkill/disrupting, e.g.:...
Neat ! I will take some time next week to give you a feedback.
Does it handle directions ? ``` case class TypeA() extends Bundle { val x, y, z = in UInt(8 bits) } case class TypeB() extends Bundle { val l, m,...
I am not sure that the Bits typing for the union is a problem, detecting sound assignments should be handled at the TaggedUnion level in my opinion.
Hmm, all the examples I have in mind to use in/out seem indeed a bit far fetched, so I am not too sure we should support the use case. ```scala...
I did test a bit the new Union stuff and it works great. But it is a bit dangerous to use : you can override assignments without noticing up until...
Removing explicitly naming the variant in choose and among was my first version but may raise issues : ```scala case class SameTypeUnion() extends TaggedUnion { val a1 = TypeA() val...
I have to check if we can propose the two possibilities (with and without explicit variants)
Ok, new versions for among and choose : - renaming the old versions with explicit variants : choose -> chooseVariant and among -> amongVariants - now choose and among are...
I had to interrupt my work. But I am still working on it as soon as I have a little time (coming week should be ok).