Romit
Romit
@CarinaWolli @ciaranha for SignIn should we just redirect user to `https://cal.com/auth/login` (in separate tab) or modal or something?
Hi @binary-koan RFR! 🙏 - Implemented the changes you suggested in https://github.com/antiwork/gumroad/pull/1890 . have a look when you get time, Thanks.
> One quick comment, looks good otherwise @binary-koan _a comment addressed! - combined three of earlier test cases to one could you please review again? Thanks!🙏
> These are effectively testing the same thing, right? (I don't think we need original_custom_field_values if they are, but checking I'm not missing something) @binary-koan addressed the comment! removed unnecessary...
All related tests are passing! - failing one is flaky and unrelated.
Hi @ershad I have addressed the comments, could you please review again? Thanks! cc @binary-koan
> Are there any other erb files? API is being migrated to React as part of the Inertia migration (#2422 cc @romitg2) so we can definitely just inline classes for...
Haven't updated Layout.tsx for SPA navigation between /ping and /api page, as the Layout.tsx component will imports Link from @inertiajs/react at the top level, which breaks server-side rendering for the...
> Ah, could you post a screencast of how it looks logged out as well? @binary-koan Thanks for pointing out, navigation sidebar was visible even when user was logged out...
@binary-koan there are some minor fixes in content is required, otherwise let me know if any code related changes/refactoring are required? Thanks!