Andrey
Andrey
Created PR #20 to support metadata
Hi William! Thank you for the response! I have been hurry enough to make this PR. Currently I found a better idea how to provide metadata support. Will push it...
Sorry for the long delay. I was deeping in draco to know more about geometry serialization features. Currently I added support not only support metadata with entires but geometry attributes...
> > > Hi Romanov, > > Thanks for pushing this contribution forward! I've started to review the PR. I've had some trouble compiling it on MacOS (a successful PR...
> This is kind of really basic, so basic it's kind of dumb, but can you explain a bit more about what kind of uses metadata has per object? Would...
> > > Thank you for the detailed reply! It's very helpful. I have an even more basic question as someone that isn't a 3D modeler: What are some typical...
Nice comments, will fix them on Monday! Thank you for review!
Hi William, I have noticed that `decode_buffer` returns "quantization_bits", "quantization_range" and "quantization_origin" (that you pass in `encode_mesh` as input args) are in draco::GeometryMetadata after buffer decoding. So I suggest changing...
And one more optimization: it seems we can leave only one `encode_buffer`. If input argument `faces` is None then `encode_point_cloud` will be invoked else `encode_mesh` will be invoked. Actually both...
fixed review comments. It would be nice you check new revision. Thanks for help!