Romain Menke

Results 782 comments of Romain Menke

I suspect this will be fixed by : https://github.com/postcss/postcss-import/pull/496 Haven't verified this but it seems to be the same issue and vite uses postcss-import.

> But from my observation, the actual Docusaurus users in China mostly work at Internet giants like Alibaba & ByteDance, and both site creators and users of these sites usually...

@niik Thank you for the speedy reply! I took a brief look at the source code of GitHub Desktop and it would be trivial to just remove the checks for...

The `fetch` polyfill also includes patches for `Request`, `Response` and `Headers`. Some of these are required up to `Safari 12.1` https://github.com/mdn/browser-compat-data/issues/2006#issuecomment-457277312

@ffxsam That is because of this issue and is unrelated to `fetch` : https://github.com/Financial-Times/polyfill-library/issues/1192

With generated custom props files you introduce multiple issues. 1) The name/id format used in design tokens is not compatible with CSS by design. Most tools just throw warnings when...

Another issue are the proposed composite types : https://design-tokens.github.io/community-group/format/#composite-types With `style-dictionary` there is a fairly good mapping between CSS properties and tokens. But composite types (part of the proposed spec)...

> Seems like this would be better integrated as a Parcel plugin for Style Dictionary that produces a CSS "virtual file" with all of the CSS variables. I would really...

> Overall, I've always kinda wondered whether a JSON-based token system is even necessary to begin with. To me, it seems that defining tokens as JSON rather than using CSS...

I haven't considered this case either in `postcss-preset-env` ```css :where(html) { --link: #4263eb; --link-visited: #ae3ec9; @media (dynamic-range: high) { --link: color(display-p3 0 .5 1); --link-visited: color(display-p3 .6 .2 1); }...