Roei Erez

Results 65 comments of Roei Erez

Do you think it worth scheduling this PR for 0.7.1 release now that the channel reserve fields are in the RPC interface (https://github.com/lightningnetwork/lnd/pull/3238)?

> Can target for 0.8 possibly. That would be great!

> Likely just a choice of wording here, but isn't dynamic Agree. Removed the word dynamically. > you introduce a costless attack for who ever you open a channel with...

> we should add some tests at the funding manager level with different values (valid and invalid) Sounds good! I will work on that.

@wpaulino I added tests for: 1. custom valid value. 2. non valid value below dust. 3. non valid value over capacity. For the functionality to be testable I needed to...

@rkfg Thanks for this issue and details. We started working on profiling the payment process and I might need your help in installing a custom build that I will create...

Thanks for your report. > I can attempt to implement this if ACKed. I don't have much experience with Dart but could be fun to dive into Sounds good.

> @roeierez looks like the https://github.com/breez/breez repo could use additional documentation as I couldn't follow the steps to build it. It's probably an environment difference issue. I will be happy...

@bolatovumar thanks. As result of your feedback I revisited both projects build documentation. I hope now it is more clear and here for any additional feedback.