Roch Devost

Results 372 comments of Roch Devost

@flovilmart Sorry for the runaround with this PR. We hadn't quite realized that the current events were incomplete when we recommended trying to use DC for this. Let me know...

@artur-ma According to the current implementation for `http` yes, it would be after the response has been received. However, these are just the bare minimum required for tracing to work...

@lucasmarcelli You can inject the current tracing context in the headers like this: ```js const headers = {} const span = tracer.scope().active() tracer.inject(span, 'http_headers', headers) client.dispatch({ path: '/', method: 'GET',...

Is the above code the first thing happening in the entry point of the application? It looks like it could be a load order issue. There were never any guarantee...

For ESM support to work properly, you'd need to use the loader. However, a loader is just a module that exports a few functions, so it should be straightforward to...

> What changed from v2.6.0 to later versions that caused express integration not to load properly? @ahmedelshenawy25 We've been moving everything to a new plugin system in the past few...

> I've been stuck on 2.2.0 because that is the only latest version that supports mongo properly @apank That could very well be a load order issue. Is the tracer...

@ahmedelshenawy25 Can you provide an example of a case that doesn't work? It looks like Node supports multiple loaders since 18.6.0, so with an example of what doesn't work we...

Just had a chat with @vdeturckheim and I now better understand what this is all doing. However, given how critical this code is, I would say to move it to...

@jmichel-bc Can you share the import code? It looks from the above snippet that you're using TypeScript, which could be hoisting your imports depending on where you call them. We...