Roch Devost

Results 372 comments of Roch Devost

This is not the first time that `init` is called in a hot path from misuse, so we should probably add a benchmark looping through the method to ensure that...

> instead of having log level channels, we'd have specific log message/event channels. @simon-id That could potentially mean a lot of channels. An alternative to this would be to keep...

@Qard What API would you propose? I agree that it would make sense to be able to turn on or off more granular logging, but I have a few concerns...

Thanks! Now I understand better the API you're looking for. I have a few concerns with the prototype that you shared: - Numerical log levels and log level comparison should...

Support for ESM requires using our loader on the CLI instead of `ts-node/esm`. It's also worth noting that it's currently experimental and has known issues with some libraries.

Can you share the new code without TypeScript and with our loader hook? Also, depending on the Node version, the option can be `--experimental-loader` instead of `--loader`, although I doubt...

Tried this locally and there is definitely a bug. A workaround for now is to put `tracer.use()` above `tracer.init()` which seems to fix it at least in the above code.

> I've tested the Connection wrapping locally and it doesn't appear to work. What error are you getting? Tried to quickly get it to run locally but I get an...

@jamiehodge Sorry for the delay, took a look and it LGTM. A quick rebase and fixing linter errors and we should be able to merge and release this soon.

@jamiehodge It did run: https://github.com/DataDog/dd-trace-js/runs/7881608840?check_suite_focus=true However, it uses the `mysql` test wait script, which in turn requires mysql be installed. The easiest way to solve this with the current test...