Rob Shakir

Results 380 comments of Rob Shakir

I think this version is a bit more confusing than what we have today - I suspect what we need is to have: ``` type CustomValidator struct { T reflect.Type...

ACK. We foresaw that this could happen - but it seemed better for the "common case" to re-use this word, as well as `Unmarshal`. Any change that results in this...

Proto and Go import paths don't have a relationship to one another. You can use the `-I` flag to `protoc` such that the import path is specified according to whatever...

What command is producing the error? What is the `protoc` command that you are using?

Wen, this was on the review stack but looks to have outstanding comments. Is there anything you need from me here?

Hi, Apologies -- I thought I had responded to this issue. Today, there is no support for generating structs for RPCs. The tasks that would be required to add such...

@GiacomoCortesi - this is an interesting question. I do agree that adding a struct tag would likely be the simplest approach. I think that we were preferring another approach just...

Generating Go code gives us a number of options to provide helpers, and validation around the data structures. For example, we generate YANG-specific helpers like `NewXXX`, `AppendXXX`, `ReplaceXXX` methods on...

In general, additional functions being generated are controlled by flags - including get, append and delete functions. Please see the flags in https://github.com/openconfig/ygot/blob/master/generator/generator.go These functions add both getters and get/create...

It looks like you might want to check our the functions like ygot.String() for assignment to the struct's fields. These avoid some of the assignment/take address repetition you have in...