Ted Senft

Results 14 comments of Ted Senft

I would like to see the impl change from being directly on level extensions, and be its own interface that can be checked for. The level extension can implement that?

Additionally, Gander is not a mod, but a collection of rendering libraries. We're purposefully keeping the level implementation separate from rendering itself, so other people that have fake levels (Immersive,...

> ```diff > - Gander.renderTicking(level, ...); > + Gander.renderTicking(level, level::tick, ...); > ``` Gander (and many other rendering level implementations) do not combine the render call and the ticking (which...

Tech, what on earth do you mean, `ClientLevel#tick` does nothing? It's calling world border ticks, ticking time, and ticking all chunks. That's FAR from not doing anything. Also, it's not...

+1 for `isEmpty` over `isBlank`/`isAbsent` - akin to `ItemStack.EMPTY` and `FluidStack.EMPTY`

Wouldn't this issue be solved by making a check in the Jetpack item, here? https://github.com/Tomson124/SimplyJetpacks-2/blob/1.12/src/main/java/tonius/simplyjetpacks/item/ItemJetpack.java#L264

IMO mod count has been mostly pointless, due to dependency/library mods and nested JAR files. It hasn't been a very useful metric.

Things to do: - [ ] TBD: Color de-application (Reset to default color) - [ ] Cleanup tasks - [ ] More documentation

Yes, still an issue. ![image](https://github.com/user-attachments/assets/5d589135-77de-45ab-ad75-fdc48249e732)

> `IAttachmentSerializer` provides important functionality that cannot be achieved with codecs: > * The ability to capture the `IAttachmentHolder` instance. You can still capture the holder -- the syntax has...