Robin Métral

Breaking change in 0.4.9: clicking the container closes the modal

9

Hi, First, thanks a lot for this library! Just wanted to report that 32140ddf7b52178fd09d46cbb0ff9d3a610f0f82 (released in `0.4.9`) introduced a major breaking change: https://user-images.githubusercontent.com/35560568/145718230-26a60082-9022-4613-83ab-1104e744fb78.mov _Note: I'm running the docs locally in...

La repo principale, [leonardomso/33-js-concepts](https://github.com/leonardomso/33-js-concepts) a été mise à jour depuis le 18 décembre. Spécifiquement, il y a eu 46 commits, avec au total 41 lignes ajoutées et 18 supprimées: [tout...

Cette repo est une traduction de [33-js-concept](https://github.com/leonardomso/33-js-concepts) par Leonardo Madonaldo. C'est bien de traduire l'introduction, mais ce qu'il faudrait, c'est **des liens vers des ressources en français** pour remplacer les...

Update section on multiple h1 elements per page

2

#### Summary Update the section on the [Heading Elements](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements) page to reflect the [recent change to the HTML spec](https://github.com/whatwg/html/pull/7829). In a nutshell, to create a heading outline... ```html Page title...

White lines between tiles on mobile Firefox

6

I'm seeing white lines between tiles on mobile Firefox (Android). Haven't reproduced on desktop or mobile Chrome. | Test app | Official demo | | --- | --- | |...

Hi! I'm in the process of migrating a component from using Popper.js v2 to Floating UI. Very happy with the rewrite fo far, especially with the native TypeScript–thanks! My component...

Copyright and id shouldn't be required in Feed typings

1

**Describe the bug** `copyright` and `id` are required in the typings for `FeedOptions` (equivalent to "channel" in the RSS 2.0 spec): https://github.com/jpmonette/feed/blob/fd77835d23990670975092c15009c75432e258ac/src/typings/index.ts#L48-L67 **Expected behavior** They shouldn't be required. The only...

[fixed] switched from KeyboardEvent.keyCode to KeyboardEvent.code

5

Fixes #952. Changes proposed: - Switch keydown event listeners to use `KeyboardEvent.code`. The legacy `KeyboardEvent.keyCode` is deprecated. Since React 18 dropped support for IE, we don't need to fall back...

Switch from KeyboardEvent.keyCode to KeyboardEvent.code

2

Hi! First of all, apologies for removing the issue template—since this isn't a bug report, I've found it hard to fill the reproduction steps. I'm wondering if there's anything stopping...

The NotificationModal should support async actions

6

## Component to amend `NotificationModal` ## Visual No changes. ## Context The component should support a use case where clicking an action button calls an API. Instead of closing the...