Rob Herley

Results 51 comments of Rob Herley

👋 @nathanleiby The `/repos/{owner}/{repo}/commits/{ref}/status` route used by `GetCombinedStatus` unfortunately only accounts for states from the [Commit Status API](https://docs.github.com/en/rest/commits/statuses#about-the-commit-statuses-api). If you want to account for all of the states from the...

👋 @benwaffle @rgarcia Unfortunately there isn't an equivalent REST API for CombinedStatus (CheckRun states + Status states) Alternatively if you wanted to use purely REST there's the [List check suites...

@swarley is this PR good to merge as is? or would you prefer support for [`attachments`](https://discord.com/developers/docs/resources/channel#attachment-object) vs. [the existing single file implementation](https://github.com/shardlab/discordrb/blob/dc27fe18463da3ccfd0f0266030aa7ad51b2c2b9/lib/discordrb/webhooks/builder.rb#L36-L43)

@swarley I can add the multi-file attachments in this PR! Just a couple impl questions: - would you prefer removing `file` from the webhook builder altogether? or should I just...

@swarley multi-file attachments should be supported now: ```ruby fileA = File.open('/Users/robherley/Pictures/photoA.png') fileB = File.open('/Users/robherley/Pictures/photoB.png') event.respond(content: 'photos!') do |builder| builder.attachments = [fileA, fileB] end ``` `file` will log out as deprecated...

👋 I made a PR to fix the logs, will be added in the next release: https://github.com/actions/download-artifact/pull/275

Not currently supported, but should totally be possible! Charm has a [list bubble](https://github.com/charmbracelet/bubbles#list) that has filter behavior when tapping `/`, this is actually used for the change extension file options...

Yea named snips would definitely be a better experience (description too?) Should be relatively easy to add to the database. My only worry is horizontal space in the terminal window,...

@rmunn Do you mind fixing the conflicts, and then we can review? To properly address the EMFILE fix, we need to check the stats (for symlinks), see my comment here:...

We can possibly fix with the `file` method in archiver: - https://www.archiverjs.com/docs/archiver#file > Appends a file given its filepath using a [lazystream](https://github.com/jpommerening/node-lazystream) wrapper to prevent issues with open file limits....