Robert E. Davidson III

Results 15 comments of Robert E. Davidson III

Any chance this will be implemented?

~Related? [Move storage encoding/decoding #224](https://github.com/onflow/cadence/issues/224)~ Nope!

Related: https://github.com/onflow/cadence/issues/452

> Is there a spec for the new codec somewhere? I wrote [this notion doc](https://www.notion.so/dapperlabs/Cadence-External-Value-Encoding-28d7849462724f9abeb80b306431abce) but it's more of a proposal than a spec. Basically: it's written in Go and...

Tangentially related work done for storage: https://github.com/onflow/cadence/issues/834

Preliminary performance impact vs the JSON codec is significant: Bigger speedup and reduction is better for the new codec. The two tests are with fake values (a string and a...

> ``` > Cadence Value: A.0102030405060708.A.12345678.NFT(Awesome?: true) > Encoding Time (ns): > JSON Average: 2216 ~ 3x > JSON Minimum: 750 ~ 1x > JSON Maximum: 91708 ~ 120x >...

The work needed to add either method is similar to the work done here: https://github.com/onflow/cadence/pull/1845#pullrequestreview-1050039961. This ticket requires more work: the FVM interface needs to be extended. Presently it has...

Would also be nice to know what it wants when I get this message: > Couldn't detect provider directory structure. This can be caused by: > • The directory is...

My understand of this code isn't very deep but from a shallow review, it looks good to me.