Robert Korulczyk

Results 25 issues of Robert Korulczyk

Right now you can disable this inspection for phpunit assertions, but it still complains about assertions from Codeception: https://github.com/Codeception/Codeception/blob/86a42614346229a689c483f6a14925767f464384/src/PHPUnit/TestCase.php#L42-L55 It would be great to create general rule for exceptions for...

I'd like to use this extension to handle mail queue, but because each job is processed separately, this becomes really slow if I send emails by SMTP (each job negotiates...

status:under discussion
type:feature

Package: https://packagist.org/packages/rob006/flarum-lang-polish [![Latest Stable Version](https://poser.pugx.org/rob006/flarum-lang-polish/v/stable)](https://packagist.org/packages/rob006/flarum-lang-polish) [![Latest Unstable Version](https://poser.pugx.org/rob006/flarum-lang-polish/v/unstable)](https://packagist.org/packages/rob006/flarum-lang-polish) I would expect that unstable badge will show `0.3.x-dev` branch and I'm pretty sure it worked in that way some time ago.

Hacktoberfest

**Changes proposed in this pull request:** Currently this alert uses generic classes and it is quite hard to distinguish this particular alert from any other alerts. Custom class should simplify...

In Polish guide there is `%` sign in hint ([source](https://github.com/yiisoft/yii2/blob/master/docs/guide-pl/start-installation.md#instalacja-yii)): ![d2faf4c1](https://cloud.githubusercontent.com/assets/5972388/17907629/1c6c7ae2-697d-11e6-8163-4a60cac095e6.png) In PDF this hint is broken: ![422c2622](https://cloud.githubusercontent.com/assets/5972388/17907658/31beb98c-697d-11e6-96ea-3ec342d4cee7.png)

bug
LaTeX/PDF

There are some issues with encoding of code samples in Polish guide. PDF: ![a78115b1](https://cloud.githubusercontent.com/assets/5972388/17907372/f1d779e0-697b-11e6-94b0-8bfb4cab97fb.png) [Source](https://github.com/yiisoft/yii2/blob/master/docs/guide-pl/start-installation.md#zalecane-ustawienia-apache-): ![b0e833ce](https://cloud.githubusercontent.com/assets/5972388/17907399/19582316-697c-11e6-8a04-7a3d5775a623.png)

bug
LaTeX/PDF

`'` in code samples is converted into `’`. Also, different countries have different styles for quotation: https://en.wikipedia.org/wiki/Quotation_mark#Specific_language_features If we do conversion, quotation should follow this rules.

LaTeX/PDF

Checklist: - [x] Correct branch: master for new features; 3.3.x for fixes - [ ] Tests pass - [ ] Code follows coding guidelines: [master](https://area51.phpbb.com/docs/master/coding-guidelines.html) and [3.3.x](https://area51.phpbb.com/docs/dev/3.3.x/development/coding_guidelines.html) - [ ]...

![88b58446](https://user-images.githubusercontent.com/5972388/69906162-5e4ce380-13bf-11ea-8a9f-08dcd8d9f64e.png) First 4 posts are sticky posts. Two of them are public - they should no be returned by command if `--post_status="draft"` filter is enabled.

Right now basic CRUD for model looks like this: ```php public function actionCreate() { $model = new User(); if ($model->load(Yii::$app->request->post()) && $model->save()) { return $this->redirect(['view', 'id' => $model->id]); } else...

type:enhancement