Ryan P

Results 18 comments of Ryan P

We'd love the help! Anything that would make sense as a parameterized test is a great candidate for refactoring into a table-driven test. [http_rulefilter_test.go](https://github.com/suborbital/reactr/blob/main/rcap/http_rulefilter_test.go) is a great example of such...

Because sending notifications on events via e-mail is a pretty common thing to do. The other was the ability to send HTTP requests.

> the moment the host sends that signal, every running service is going to receive it I'm fairly certain if you invoke `kill -15 ` only the provided pid will...

Would it make sense to not rely on the zip at all but instead to introduce the concept of a template "source" . If we have a dedicated templates directory,...

Yep you get the idea, we come up with a well-defined structure for template metadata and use that as a means to reference a specific template resource itself. I haven't...

We will rebase and clean uo this PR by the end of the week (hooefully Wednesday or Thursday possible it wont be until Friday though) now. Any reviews after rebasing...

:+1: I'm actually all for making these handles more interface friendly. Might I make a suggestion that we move `Close() error` to the `Handle` interface in [handle.go]( https://github.com/confluentinc/confluent-kafka-go/blob/master/kafka/handle.go#L33). There are...

Looks like it should be compiling correctly at a glance. Do we by chance capture the output generated when we execute `./configure` and `make`? Might be a good idea to...

@g-rd, as of today we are still tracking interest but it doesn't currently have a place on the roadmap.

Thanks for bringing this to our attention. We will look into this a bit more to figure out what exactly the best practice is here. I suspect omitting the license...