rnitta

Github review comment should be "REQUEST_CHANGES" mode

3

https://github.com/prontolabs/pronto/blob/899c6f270ed80cce1585abf1cf1b0006899021f3/lib/pronto/github.rb#L52 Now it is submitted with "COMMENT" mode. it should be "REQUEST_CHANGES" (and this is also semantic). Or, the mode should be selectable by user. thoughts? see also: https://octokit.github.io/octokit.rb/Octokit/Client/Reviews.html#create_pull_request_review-instance_method https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review

There are mixed tabs and spaces indentations on Example app ViewController. It doesn't matter much with Xcode, but on Github, it makes hard to read the code. https://github.com/Ramotion/fluid-slider/blob/master/Example/Example/ViewController.swift I Replaced...

should exit 1 if rubocop error raised

1

I'm using Rubocop with Saddler like [this](https://github.com/packsaddle/example-circle_ci-pull_request_review) in Rails project on CircleCI hooked by Github push. When there are Rubocop error with my code, CircleCI build ends with no errors...

`this._getInstallDirectory()` create dir (recursively) if not exists and return the path of the dir.