Raphael Mitsch

Results 125 comments of Raphael Mitsch

Can confirm, happens to me too. If this is actually irrelevant, an option to suppress warnings instead of printing them would be nice.

> Have you looked at the timing for this yet? Not yet, wanted to confirm this approach is acceptable before.

> If the basic `pkg_resources` checks are extremely slow we can immediately stop working on it. (I don't think they will be, though.) So far they felt pretty instantaneous. Will...

Running the validation with this cobbled together list of requirements ``` scipy umap transformers>=3.4.0,=1.0.1,=1.3.0,=0.6.0,=1.0.0,=1.0.0,=0.61.1,=0.11.6,=1.0.0a0 streamlit wandb>=0.12.4,=0.10.1,=1.0.0a0 spacy-lookups-data>=1.0.0,

> I think the conflicting dependencies message needs more info. Displaying the full message from `VersionConflict.report()` now. This should show `streamlit 1.9.2 has requirement click=7.0, but you have click 8.1.3.`...

> The merge undid some other edits? Weird. But only https://github.com/explosion/spaCy/pull/11226/commits/f58195569c93249d5a1ccbb5fa000706322498e4, right? Re-added the change.

> * there are multiple components with thresholds, can this be implemented more generally? Should be possible. Would it be acceptable if we ditch the automatic component recognition then and...

Are there smart(-ish) ways to... 1. ...dynamically identify whether a component is suited for the find-threshold command? 2. ...map the correct scorer method to the component? Like `score_spans()` for `span_finder`...

> No, I think we need to rely on the user to provide a path to the threshold in the config and the scores key to optimize. It's not just...

The latest commit should be closer to a generic solution. Two remarks: - `beta` hasn't been introduced yet. I'd add it as optional argument to `PRFScore` to pass it forward...