Riya Mehta
Riya Mehta
@matthewstevenson88, I made 2 changes and it looks like 2/3 linux runs are passing. tests(11) is failing with an [error](https://github.com/grpc/grpc-java/actions/runs/8788883897/job/24117364595?pr=11113#step:7:1753) in code that was not affected by this PR, so...
> LGTM, thanks @rmehta19! When you have a chance, please remove "draft" to the PR title and can we say a bit more in the CL description including pointing to...
> To make sure I understand, s2a is the public API, and s2a/channel and s2a/handshaker are internal APIs. Are those internal APIs to be used anywhere, even within Google? Correct...
Thank you for reviewing @erm-g, @ejona86 ! I have addressed the comments in separate commits. PTAL when you get a chance, and provide any additional feedback.
@ejona86, PTAL when you get a chance, and leave any additional feedback. Thank you in advance! @erm-g & @matthewstevenson88 have approved these changes.
Thanks @larry-safran, the item's have been addressed
Thanks for the review @larry-safran ! Please let me know if there is anything else to address.
Thanks for the comments @ejona86; I'll address them in separate commits at https://github.com/grpc/grpc-java/pull/11534. Let me know if you prefer separate PRs for them, or any other way of organizing.
@ejona86 , @larry-safran I have addressed all the comments on this PR in the following 3 PRs: - https://github.com/grpc/grpc-java/pull/11534 - https://github.com/grpc/grpc-java/pull/11539 - https://github.com/grpc/grpc-java/pull/11540 PTAL at these 3 and leave any...
cc: @xmenxk