rl2939

Results 8 comments of rl2939

I believe the PR was reverted (not included). @xsub Is there anything that needs to be corrected in this PR?

> the licenses file is missing artwork info ~I set up an issue here:~ EDIT: Closed the issue.

It seems to be coming from Tropicana. However, the only thing that changed from 2.0.0 to 2.1.0 for this module was the copyright year (https://gitlab.com/sonusdept/sonusmodular/-/commit/e5c89697af1af360da8ba63708b01f2a155db351?page=2). From the plugin-validation: ``` [dpf]...

I am unable to update this pull request any further because I keep getting compile errors. At this point, I can only merge the main branch in without having checks...

> I don't see any compile errors? That is because I am still building off of an older version of Voxglitch. However, when I try to build off of the...

Since you made the 2.0.11 release, could you please send the updates to Cardinal and merge the current branch as well?

> we can just synthesize it, no? You can. The problem here is that making a clap takes up a lot of HP, even more so than other percussion noises....

> We could of course patch this I don't think that is a good idea, because the assets for the modules are [licensed CC BY-NC-ND](https://github.com/AScustomWorks/AS/blob/d90eed32afe6745454ef6ac6e391e0d5dc90ec4b/README.md?plain=1#L8).