Ryan Knell comments

Results 56 comments of


                                            Ryan Knell

Added Range request support to the File handler

Hey I just wanted to comment on this one - I am totally in favour of adding this feature, but I'm hesitant to drag in another dependency, especially as its...

Add support for route handlers

Hey guys, agree it is nice and what i have done in the past for a larger project is created a class called AlfredRoute that had a list of routes...

Trailing comma in JSON breaks the whole thing

Ok, so at the end of the day, its invalid JSON. Darts JSON decoder falls over: and even the javascript JSON decoder will throw if you put a trailing comma:...

Trailing comma in JSON breaks the whole thing

we definitely don't want to crash the server!

Trailing comma in JSON breaks the whole thing

I just went to have a look at it and the most recent test is there to handle invalid JSON input and return a 400 (thereby not crashing the server)...

Trailing comma in JSON breaks the whole thing

That release was literally the one that added the test for dodgy JSON so it should be working. It might be that the published version doesn't include the code -...

Trailing comma in JSON breaks the whole thing

Ahhhh.... So I think its being caused by you using a try catch block and then trying to return something. I can reproduce it with this: ```dart test('it handles invalid...

Trailing comma in JSON breaks the whole thing

should be resolved in v0.1.6+1

HTTP/2

Haven't thought about it yet! To be fair I have never used http/2 for anything as of yet so it's one of those I don't know what I don't know...

Server Directory Traversal - Critical Vulnerabilities

Thanks @seceba and @d-markey I'll get a new version pushed up today. Really good catch