Roopesh Manda

Results 79 comments of Roopesh Manda

> "streamingFormat": { wondering why this didnt trigger a breaking change as a property is being dropped entirely? --- Refers to: specification/mediaservices/resource-manager/Microsoft.Media/Encoding/preview/2022-05-01-preview/Encoding.json:38 in bd0f0ba. [](commit_id = bd0f0bac9811f802cbe8431450fca6696b0393ba, deletion_comment = False)

> "type": "string" enum of country names? --- Refers to: specification/databox/resource-manager/Microsoft.DataBox/stable/2022-09-01/databox.json:5869 in 78d5947. [](commit_id = 78d59478564b815cc41b223b3ad4e521ae121f37, deletion_comment = False)

> "modelAsExtensible": true, did u want this to be modelAsString? --- Refers to: specification/databox/resource-manager/Microsoft.DataBox/stable/2022-09-01/databox.json:3687 in 215f002. [](commit_id = 215f002e4625aef0292eddf444c632bc0519d521, deletion_comment = False)

> "modelAsExtensible": true, I see that you have used this everywhere but I also see that x-ms-enum does not really have a property called modelAsExtensible. --- In reply to: [1284533856](https://github.com/Azure/azure-rest-api-specs/pull/20717#issuecomment-1284533856)...

> "modelAsExtensible": true, I will approve this now but please get all of these corrected to the real intent that you want to code up. --- In reply to: [1284535268](https://github.com/Azure/azure-rest-api-specs/pull/20717#issuecomment-1284535268)...

> "204": { you dont need a 204 for POST. Pl add a 200 with the definition of the response body --- In reply to: [1286377645](https://github.com/Azure/azure-rest-api-specs/pull/21148#issuecomment-1286377645) [](http://example.com/codeflow?ancestors=1286377645) --- Refers to:...

> > > ``` > > > "204": { > > > ``` > > > > > > you dont need a 204 for POST. Pl add a 200...

> "204": { Per offline conversation, there is no response being returned at the end of the polling of this API --- In reply to: [1286377645](https://github.com/Azure/azure-rest-api-specs/pull/21148#issuecomment-1286377645) [](http://example.com/codeflow?ancestors=1286377645,1286377645) --- Refers to:...

> "Status": { should be modelled as a proxy resource with along with the top level envelope --- Refers to: specification/mediaservices/resource-manager/Microsoft.Media/Streaming/stable/2022-11-01/streamingservice.json:2652 in 7ae44c4. [](commit_id = 7ae44c48f8994ed7e3a39407c4482bc95a391c6f, deletion_comment = False)

> "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Media/mediaservices/{accountName}/liveEvents/{liveEventName}/trackIngestHeartbeat": { resourceCollection names MUST be nouns and plural --- Refers to: specification/mediaservices/resource-manager/Microsoft.Media/Streaming/stable/2022-11-01/streamingservice.json:587 in 7ae44c4. [](commit_id = 7ae44c48f8994ed7e3a39407c4482bc95a391c6f, deletion_comment = False)