rkinder2023

Note that this is not complete yet, but good enough to get S1G beacons parsed. Still to do is modify the core Dot11 class to add support for S1G beacon...

> ## [Codecov](https://app.codecov.io/gh/secdev/scapy/pull/4442?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev) Report > All modified and coverable lines are covered by tests ✅ > > > Project coverage is 48.99%. Comparing base [(`1e857c9`)](https://app.codecov.io/gh/secdev/scapy/commit/1e857c9614724a984c7101ba3330568e921036de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev) to head [(`efef84f`)](https://app.codecov.io/gh/secdev/scapy/commit/efef84f54faf8b57c3e6e6c1941942d63e383d3c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secdev). > >...

Here is the patch. ``` diff --git a/scapy/layers/dot11.py b/scapy/layers/dot11.py index 8ed4d38c..45b942af 100644 --- a/scapy/layers/dot11.py +++ b/scapy/layers/dot11.py @@ -712,7 +712,7 @@ class Dot11(Packet): _Dot11MacField("addr1", ETHER_ANY, 1), ConditionalField( _Dot11MacField("addr2", ETHER_ANY, 2), -...

PS: would appreciate if I can have branch creation permissions so I can just submit a PR.

@gpotter2, thanks - I'll give it a try.

@gpotter2, who do I ping to get help on the PR? I see that coverage went down significantly with my patch, although I can't see why.

I'm really not sure what to do here as the commit into my master branch shows coverage at the correct level (80.73%). I don't know why coverage is reported so...

G'day folks, can I please get approval for the workflow (review would be great too :)? @gpotter2, @guedou, @p-l- ?

Could I please get another review? I have modified to use a set on the 'type in' as per @p-l-, and updated the frame control field to split into three...

Hi folks, any further review or comments? @p-l- @gpotter2 @guedou?