Riva Junior comments

Results 8 comments of


                                            Riva Junior

Make milligram a bit more flexible

For sass variables can be override, it's nice to have `!default` on it's definitions

How can I get this working for horizontal scrolling?

> @demonmind sorry for that, I made a vanilla JS version for you, but I have not tested it very well, so please give it a try: > > ```...

chore: enable not breaking changes features

> @rivajunior there's still some changes that can remain in this PR, if you're willing to update it. @ljharb I will take a look in it again

[react] Lit Element in React Component Doesn't Apply Default Prop Value on Re-render without Property Set

> Another workaround on the consumer side without modifying the wrapper generator code is to simply wrap it with another React component that defaults the prop like this: https://codesandbox.io/p/sandbox/falling-rain-vw3cww?file=%2Fsrc%2FMyComponentWrapped.tsx The...

[react] Lit Element in React Component Doesn't Apply Default Prop Value on Re-render without Property Set

> The workaround at the wrapper creation layer is clever but not ideal as it requires duplicating the default props in the option. I've managed to reduce the duplication by...

[react] Lit Element in React Component Doesn't Apply Default Prop Value on Re-render without Property Set

Hey @augustjk I am sorry about the delay. I forgot about this issue. > I'm curious if you have direct, non-React wrapped, consumers of the custom elements too for your...

Missing destroy() method

Any news?

Rule Change: support TypeScript syntax in no-duplicate-imports

> I'm okay with adding an option. I don't think `allowTypeImports` accurately represents what's wanted here. It seems like we want to say, "It's okay to have duplicate imports so...