Rishi Prasad Sulakhe comments

Results 18 comments of


                                            Rishi Prasad Sulakhe

/assign

/attempt #1327

@MayaRainer Reopened #1692 Just need a final review.

Thanks. Let me add a component for modal sidebar here itself.

Thanks @MayaRainer for update That makes sense! I’ll update Sheet to support setting modal={true} and use backdrop.

@MayaRainer I have updated the mobile view with `Sheet ` component and updated the screenshots/demo for same. Just need final review.

@MayaRainer i have fixed the test. Thanks.

@MayaRainer Thanks for the review. I have addressed all your reviews with best fix possible.

@MayaRainer fixed all requested changes. Also looks like other unrelated tests are failing in workflow earlier. Can we check again?

Hello @alisman , @inodb Made a pull request for this issue. https://github.com/cBioPortal/cbioportal-frontend/pull/5099 Thankyou!