Riley Shaw

Results 57 comments of Riley Shaw

Thank you for fixing this. I just applied some of the changes locally and saw a huge size reduction, similar to what @bcat reported. What’s the status on landing this...

Yay! Thanks for giving this an update @drashna. Excited for it to land 🥳🎈

I'm not convinced that the proposed design actually improves the interface. Biggest concern is that there's no longer a text input for the info hash..? I'd be happy to give...

Alright! I'll work on a re-redesign in my spare time. I've got a busy month coming up, so you might want to just go ahead with the existing design. I...

I should have posted an update here earlier – I'm no-longer working on this :disappointed:

Scroll isn't recognized. This is only really an issue for horizontal scrolling, though it may also cause problems if there are enough events to necessitate vertical scrolling.

Should we add a `5.x` tag to keep track of this issue? @dougwilson, I can make a PR to strip the "referrer" special casing out of https://github.com/expressjs/express/blob/5.0/lib/request.js if you want...

@wesleytodd sounds good! Something like: ``` console.warn('Deprecation warning: the "Referrer" header is non-standard, and special-casing for it will be dropped in version 6.0. See https://github.com/expressjs/express/issues/3951 for further details.'); ``` ?

@wesleytodd sounds good! Sorry for the delay, I just added a PR to the `5.0` branch (https://github.com/expressjs/express/pull/4106). Let me know if you'd like to see any changes.

@dougwilson thanks for the clarification, and sorry for the delay! I just updated the PR. Now, if someone calls: - `req.get('referer')` and receives `this.headers.referrer`, or - `req.get('referrer')` and receives `this.headers.referer`...