Richard Levasseur comments

Results 357 comments of


                                            Richard Levasseur

rules/python: Add a `coverage_tool` attribute to `py_runtime`.

I'll have a look. (coincidentally, we made essentially this same change internally a couple months ago, but since we don't use toolchains and do embedded hermetic python, our impl looks...

rules/python: Add a `coverage_tool` attribute to `py_runtime`.

@c-mita Can you review/approve/merge, please?

rules/python: Add a `coverage_tool` attribute to `py_runtime`.

@c-mita @comius signal boost

Allow .pyi (python interface) files to be sources for py_library/binary

I think overall, I'm +1 to the idea of having them as a separate attribute on the `py_*` rules. The main compelling rationales being (1) srcs are understood to be...

Allow rules to detect tool configuration

Correct. How do I select/detect the exec constraint? Or is that still a FR?

Allow rules to detect tool configuration

Another case that select()'ing on the tool config would make easier: A feature we're looking to add to the Python rules is having a flag that specifies what debugger to...

Let Python stubs respect RUNFILES_* while finding the module space

Ok, I think I set the labels up correctly here for the "import it into google" people to process it. If you don't hear back in a day that the...

Let Python stubs respect RUNFILES_* while finding the module space

Just to give an update: I've been fighting with our internal windows test environment to make the test added to python_stub_test.sh pass for the last day or so. For whatever...

Let Python stubs respect RUNFILES_* while finding the module space

Woo, got everything happy! Code is out for review internally; should land early next week.

incompatible_build_transitive_python_runfiles

Oh, thanks for pointing those out. Yes, that would exacerbate it. I'll have a look at #14740