Richard Tier

Results 11 comments of Richard Tier

I prefer this apporach too `@mock.patch("tenacity.nap.time.sleep", MagicMock())` as that will auto-tear down after the test is finished, but monkey patching `func.retry.sleep = mock.Mock()` does not not tear down the monkey-patch...

I solve this by explicitly defining an autousef fixture in project's `conftest.py`: ``` @pytest.fixture(autouse=True) def reset_feature_flags(settings): settings.FEATURE_FLAGS = {**settings.FEATURE_FLAGS} ```` then in the tests I can do: ``` def test_foo(settings):...

@cybergrind Good point. the resetting should inded occur _after_ However, if we do `settings.FEATURE_FLAGS = {**settings.FEATURE_FLAGS}` _after_ then we're not resetting them: we're using the values that were mutated in...

here's a mixin. add it to the view ```py class PreventRevalidationMixin: NO_REVALIDATION_FIELD_NAMES = ['captcha'] def process_step(self, form): for name in self.NO_REVALIDATION_FIELD_NAMES: if name in form.fields: self.storage.extra_data[f'skip_validation{name}'] = True return super().process_step(form)...

the package does not claim to support django 1.7 https://github.com/grantmcconnaughey/django-field-history/blob/master/setup.py#L63

This will help with my scenario: static s3 bucket behind cloudfront. I will try the natahouse fork until it's a vanilla feature edlt: that helped, but I don't want the...

for now I have forked the lint plugin and simply removed '/private' from the path. not great but it removes the blocker.

Hi, thanks for raising this. Please make a pull request and I will merge.

hi, sorry took long time to respond. Please make a pull request with your fix and I will merge it.

This is great, thanks for that. Can you please add tests?