Rich Milns comments

Results 7 comments of


                                            Rich Milns

Sort and clean imports

+1 for sorting/cleaning `use` statements, and a short array conversion option would be so handy

Sort and clean imports

I think alphabetical makes most sense to me.

[NFR] ORM: add the ability to return a custom Phalcon\Mvc\Model\Row class instance

I've had a go at adding this functionality - it's my first time using Zephir but I was able to test this and it seems to be working as outlined...

[NFR] ORM: add the ability to return a custom Phalcon\Mvc\Model\Row class instance

I just saw the announcement about 3.4.2 being the last release for 3.x. My code above was based on the 3.4.x branch of Phalcon, so I guess it might be...

[NFR] ORM: add the ability to return a custom Phalcon\Mvc\Model\Row class instance

I was hoping to re-open this if that's OK with everyone 👍

Expressions are not being parsed

For me, it seems to be that the use of arithmetic causes issues: ```css .heading { font-size: clamp(1.4rem, 3vw + 1rem, 2rem); } ``` Whereas this example gets parsed without...

The `id` is missing on the the visibile input, unfortunately by default

My workaround is to add a new ID (prefixed with an underscore) to the altInput DOM element and then update the corresponding label: ```js flatpickr('#date', { allowInput: true, altInput: true,...