richardbiddle comments

Repositories
Issues
Comments

Results 3 comments of


                                            richardbiddle

Quote: "USDUSD" is missing

All conversions where source and destination are the same have been removed as well. It could be due to the issue mentioned above https://github.com/apilayer/currencylayer-API/issues/14 and https://github.com/apilayer/currencylayer-API/issues/15

Currency rate for base currency seems wrong

It looks like the fix to this issue was to remove the USDUSD (and all where source and destination currency was the same) https://github.com/apilayer/currencylayer-API/issues/16

Add macro which returns the largest partition

Please consider the case where partition_id can be '`__STREAMING_UNPARTITIONED__`', maybe need to exclude like the `__NULL__` case, or exclude any that start with `__`?