André R. de Miranda

Results 10 comments of André R. de Miranda

> There is a small issue on a third party lib, please take a look in the comments. Changed version to 1.19

@ricardozanini @spolti Are all inputs valid? 1. ```yaml id: Valid DataInputSchema version: '1.0' specVersion: '0.8' start: Start dataInputSchema: "file://testdata/datainputschema.json" ... ``` 2. ```yaml id: Valid DataInputSchema version: '1.0' specVersion: '0.8'...

@ricardozanini @spolti Another question, it wasn't clear to me in the specification. Which is right, JSON with or without quotes? ``` 1. ```yaml id: Valid DataInputSchema version: '1.0' specVersion: '0.8'...

@ricardozanini @spolti With the patch all cases below will work. ``` dataInputSchema: "{\"key\": \"value\"}" dataInputSchema: {"key": "value"} dataInputSchema: file://... dataInputSchema: schema: "{\"key\": \"value\"}" failOnValidationErrors: true dataInputSchema: schema: {"key": "value"} failOnValidationErrors:...

What is your opinion on generating the SDK code based on the json schema?https://github.com/serverlessworkflow/specification/blob/main/schema/workflow.yaml

I understand, generating code can get very complex. Another very interesting way to make a json schema interpreter with libraries: https://cuelang.org or https://github.com/xeipuuv/gojsonschema. Is it simpler than generating the code...

I think these features below can be using jsonschema validation: * Parse workflow JSON and YAML definitions * Validate workflow definitions (Schema) * Custom error messages Development the validation (e.g....

> just a reminder about it: > > > Just provide validation that certain definition file is valid according to the schema (using https://github.com/xeipuuv/gojsonschema) . And maybe a shortcut call...

I created the [repository](https://github.com/galgotech/sdk-go-1.0) with a proposal to implement the new DSL, if I follow this implementation I will create a PR. This repository implemented a basic "validator" using jsonschema...

@Kshitiz1403 A contribution in this scenario. In the [Monitor Job Example](https://github.com/serverlessworkflow/specification/tree/0.8.x/examples#monitor-job-example), it has a sleep state, avoiding a loop that can cause many calls, in a very short time for...