Rhys Thomas

Results 25 comments of Rhys Thomas

That sounds good, will give it a go

We should definitely implement this - I've been caught out by the values in `hrdic.Map.grains` being off by one compared to indices in a `hrdic.Map`...

Might be good to move the handling of BSE images to a separate class. There are cases where it's useful to be able to check the BSE image for a...

I believe the data that we use in the example notebook is now contained within the `tests` folder and is small compared to the old example data. The old example...

In investigating this, I've realised that number in the DaVis header is not the sub-windows size but the step size. We should clarify this in the code. The effective shear...

This is the conclusion I came to when I compared the different programs. ![image](https://github.com/MechMicroMan/DefDAP/assets/19435305/fc7c1a2f-876f-4e37-8908-a30fa152b0a6)

There might be some more inspiration for improvements from these packages https://github.com/moble/quaternion I particularly like this, which adds a quaternion dtype to numpy https://github.com/moble/quaternionic

We're hoping to make a new release in the not too distant future! Would be nice to include any optimisation to runtime for quaternion operations. I think the slow speeds...

The DIC min grain size should correspond approximately to the EBSD min grain size. There should be a check of this. The EBSD step size is taken from the file...

Have fixed the problems you stated I think - using a masked array instead of mutation and now generates a null mask in a better way (?) Moat of the...