Ralph Hopman

Results 9 comments of Ralph Hopman

This is my first PR on the project so I hope I did everything right. Is there anybody who could review this, and let me know if there's anything I...

@PC-11-00 @alberto-art3ch @janez89 @somasorosdpc is anybody able to review this PR please? I realize it touches a lot of files but the changes are all pretty minor. If somebody has...

Thanks, @adamsaghy! I've resolved the merge conflicts. Please let me know if there's anything else I can do to assist in the process.

Apologies @adamsaghy, the linting issue should be fixed now.

@JaySoni1 I did some digging into the GLIM application process on the backend. My understanding is as follows: - You have to generate your own `applicationId` which serves to link...

Implementation looks good to me. I would recommend adding a test in `SearchResourcesTest.java`, something like this: ```java @Test public void searchSavingsAndSharesHaveEntityStatus() { // Create client String jsonPayload = ClientHelper.getBasicClientAsJSON(ClientHelper.DEFAULT_OFFICE_ID, ClientHelper.LEGALFORM_ID_PERSON,...

@Akshat-Soni02 I think it's a simple Spotless issue. Here's a properly formatted version of the test (I hope): ```java @Test public void searchSavingsAndSharesHaveEntityStatus() { // Create client String jsonPayload =...

@Akshat-Soni02 I am not getting that error. Could you fix the formatting and see if it still fails?

@adamsaghy I provided the fix for the Spotless issue in https://github.com/apache/fineract/pull/5166#issuecomment-3704094026. @Akshat-Soni02 can you please apply this in the PR? Or just run `./gradlew :integration-tests:spotlessApply`; that should also fix it.