Robert Kean
Robert Kean
just weighing in.... @matthewadams , does your company require you to use GA-only sdk's and libraries for your production releases? Are you asking for the pieces you need pulled out...
OK. thanks for the response.
One thing that I forgot to note... I do not have an Ethernet board to test the USER_ETHERNET features. I think that I covered that area correctly, however, if someone...
I'd also be interested in others' thoughts regarding the "turn WiFi off" comments from code rabbit.
> I'm afraid I'll have to say no to this PR. > > First, if you disable WiFi, how do you enable it again? Even AP mode on button press...
> ESPNow and wifi hardware are tightly entangled, it is not possible to disable wifi and have ESPNow enabled, at least in arduino framework afaik. so I should ignore coderabbit's...
I've made the code changes noted above. But, I still have to test the rebuild. I'll do that tonight and refresh the PR.
I've made the changes noted above and improved the WiFi settings page by moving the disable setting to the bottom of the page and included a warning with required confirmation...
> Did not test yet but from reading the code the double-check to disable it seems acceptable. Does ESPNow work like this? also, wifi-sleep is no longer respected. Not sure...
> > Can you point me to where the wifi-sleep is not respected? I can't find any of my modifications that impacted that. thanks > > `WiFi.setSleep()` is not executed....