Hector Martinez Lopez

Results 11 comments of Hector Martinez Lopez

> thanks @rh-hemartin, just one comment since we changed it to alpha and disabled Thanks for the suggestion, I applied it. This should be squashed when merged?

> Can we create an e2e test similar to `TestMTChannelBrokerNewTriggerFilters` > > https://github.com/knative/eventing/blob/2aa8985d582b20f07ef7f0ea3ef66ddee92585cb/test/rekt/new_trigger_filters_test.go#L34 I can't reply to your standalone comments, so I'm quoting you... I'm having trouble with the `eventshub`...

> > How can I get the reconciler-test image uploaded and used? I tried with ko build vendor/knative.dev/reconciler-test/cmd/eventshub but it has some problems too: > > @rh-hemartin can you try...

> @rh-hemartin can you paste the full logs you're getting? On which OS are you on? Hey! Getting all the logs together I think I found the problem, so thanks!...

Hey, I will be away from my computer for three weeks, I will continue with this then. I'm now progressing on the e2e rekt test. I pushed the last changes,...

> Can we create an e2e test similar to `TestMTChannelBrokerNewTriggerFilters` > > https://github.com/knative/eventing/blob/2aa8985d582b20f07ef7f0ea3ef66ddee92585cb/test/rekt/new_trigger_filters_test.go#L34 I created a rekt test similar to that, I had to introduce changes to some places, as...

> @rh-hemartin with the switch to disabled by default the tests are now failing, we need to add a new config-features configmap for tests with the feature enabled here https://github.com/knative/eventing/tree/main/test/config...

So the idea would be to add a `filters` instead that enables the user to do things like (don't mind the indentation, couldn't get it right): ``` kind: APISourceServer ......

I think it would make more sense to put it behind another flag, something like `new-apiserversource-filters`? By the way, I'm willing to contribute this change, so I'm assigning myself. Edit:...