rfalke comments

Results 49 comments of


                                            rfalke

Use break block instead of goto

Same problem with continue blocks in intermediate_15_loop_with_continue_and_block()

Implement new Code Generator

This sounds like a big task. Since I think the rewrite for capstone (https://github.com/BoomerangDecompiler/boomerang/pull/69) is also a bit task I would suggest to finish one first.

No stdout output for default parallel_workers=1

Sadly I don't see any messages from `print()` when parallel_workers is 1. Thanks for clearing up on the other point.

X86 logical instructions need to model the O(verflow) flag more precisely

Just my two cents: The SF, ZF and PF can be computed just from the result. For the other flags you need the operation (not, inc, add,...) and maybe also...

Regression: Missing printf calls

Also others like `isWhitespace()` in https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/compiler_optimizations/x64_elf look broken.

x87: fbstp wrongly decompiled as cast

I don't see a "b" data type mostly because there are no operations except load and store. For me there is a BCD storage/serialization format and methods which convert from...

Multiple issues in new subject for arm64 stX instructions

See also https://github.com/rfalke/decompiler-subjects/blob/master/from_holdec/arm64_stX/arm64_macho/by_holdec_regtest.c

x87: Doesn't load float or int constants from read-only sections

I my opinion this is the issue which would improve the decompiler output the most.

C-Output: return expressions directly

Because this case has a larger expression or in general? So what about a simpler case? Current output: ``` word32 intermediate_1_ternary_blocks(Eq_11 dwArg04) { word32 eax_10; if (dwArg04 == 0x2A) eax_10...