Reiley Yang
Reiley Yang
@findmyway
FYI - how OpenTelemetry Python did this https://github.com/open-telemetry/opentelemetry-python/pull/228
Thanks for your contribution, @xoscar! Would you update the PR title to capture the intention? It's hard to understand what "39 web application" is unless someone reads through the details...
> @wph95 , @cedricziel , @mic-max , @open-telemetry/demo-approvers - ready for final reviews I don't know how to effectively review any PR that has more than a hundred files. Maybe...
> Is there an equivalent of this in the dotnet repo @reyang ? Nope, I guess the model is different. OpenTelemetry .NET does not redistribute any source or binary. I...
This decision - once made - is hard to revert. The binary file will always sit in the commit history and be part of every git clone. Maybe consider using...
> @reyang , I'm new to this but I would like to contribute and work on this, will drop a PR later, try to fix ConsoleExporter first. Thanks @jackyshang12321, I've...
> **What is the expected behavior?** > > If the logger factory is disposed, the console exporter should stop exporting data. (or we can keep exporting the data but put...
> Hi @reyang , Could you please help review the updated PR when you get a chance, appreciated if any suggestions or feedback I've replied here https://github.com/open-telemetry/opentelemetry-dotnet/pull/3578#pullrequestreview-1076701507.
@alanwest would you elaborate the importance and urgency of this change? I can imagine with "Event" API effort, we might reconsider if LogLevel should be made optional. Also consider Scopes...