Hunter Kelly

Results 21 comments of Hunter Kelly

As an outside observer (i.e. someone who would like to use the library), does this really need a reviewer with deep knowledge of compressors? As a user of the library,...

@shurcooL yes some people want only things in the base go distribution. The issue is about including/merging bzip2 in the standard library - see the original issue description. @dsnet sure...

Hi Chris, just to let you know, I was never the developer for this project - I was using it in one of my own projects, and with the permission...

No, it doesn't complete functions that are definitely in scope. If I load the module again using `:l` it still doesn't complete.

This has come up before, there's another open PR about this: https://github.com/npryce/adr-tools/pull/75 Both PRs fail the CI checks, btw.

Isn't this a bit backwards with expectations though? One often uses an ENV var to override what's checked in of the default state; it allows easy switching of behaviour at...

Looking back at original use case reported in the issue, I think your first response makes the most sense - warn/puke if env var exists as well as .adr-dir and...

There are already 2 other open PRs to fix this same issue. I don't think it's going to change anytime soon 😅

Makes sense to me. Another place we've seen discussion take place is on the PR for the ADR itself, but even then there was a "Proposal" phase that gets committed...

I'm getting this as well. Digging through logs now to find some example data...