Erwan Renaut
Erwan Renaut
SSD validation is made here: https://github.com/threefoldtech/tfchain/blob/development/substrate-node/support/src/resources.rs#L42-L45 after a call to `get_resources()` https://github.com/threefoldtech/tfchain/blob/eb36aa90df2d60cb1a534997903821fc68a096f1/substrate-node/pallets/pallet-tfgrid/src/node.rs#L392-L398 Btw I was checking code and this check is done when ZOS twin make a call to `create_node()`...
On proposed solution, dropping validation on minimum SSD size will allow to register some nodes with no SSD nor HDD (or very few storage capacity) which we want to avoid...
Deployed on devnet Can check if everything is ok @muhamadazmy
> * The council can call `force_reset_farm_ip` to force unreserve these IPs I think I found origin of the `force_reset_farm_ip()` creation. See here: https://github.com/threefoldtech/tfchain/pull/308 https://github.com/threefoldtech/tfchain/commit/072bdc89b3b92ac71f65b594befb5e696fcbebca My guess is when trying...
Great investigation ! Thank you. I am ok with the solution since code is already in place (probably for same reason) and had already been used to restore coherency of...
Edit: OUTDATED I had a look in code and, indeed, node state is not taken into account while billing (node state is only checked to prevent creating node/rent contracts while...
Thank you all for your inputs. To sum up, not checking if node is down during the billing is done on purpose in all contexts: 1. `Node contract`: since consumption...
> * Set a Minimum and a Maximum Duration : Ensure the duration is neither too short nor too long. Actually DAO proposal duration is fixed to 30 days (default)...
So 2 things: 1. In `propose()` I would "hard code" min threshold and if threshold lower then return something like `Error::::TresholdToLow` 2. In `propose()` I would "hard code" min motion...
Already live on mainnet so it can be closed