Erik Marks

Results 52 comments of Erik Marks

Hey @mconnelly8, what's the state of 4.x (is it ready for production?) and when do you guys plan to ship documentation?

I think we should switch over to `@scure`, fork it, apply our patches, and then consolidate around that. Per [its readme](https://www.npmjs.com/package/@scure/bip39), the benefits of `@scure/bip39` over `bip39` are: - Is...

The Snaps team recommends using [`@scure/bip39`](https://npmjs.com/package/@scure/bip39), as that's what we use in [`@metamask/key-tree`](https://github.com/MetaMask/key-tree/blob/main/package.json#L32).

@paulmillr all of the concerns Mark are raising are due to [actual vulnerabilities](https://halborn.com/disclosures/demonic-vulnerability/) that were disclosed to us and patched. Mark is not attacking your work or the package, everything...

@TalhaAli00 I like that. Your format with some modifications: ```js params: { // object instead of array "eip155" : { "chains": ["1"], // namespace omitted from chainId "methods": ["eth_sendTransaction", "eth_signTransaction",...

@pedrouid great point. Let's stick with the existing format!

Until somebody takes the time to reconfigure typedoc and publishing to GitHub Pages in CI, I just deleted the `gh-pages` branch and thereby unpublished the docs page (https://metamask.github.io/controllers).

Upon closer review, this issue is significantly complicated by our use of wildcard permissions for the snap permissions themselves. For example, in the `PermissionController` state, the permission to communicate with...

`8.1.10` is live on Firefox and is rolling out to Chrome and Brave as we speak. Can someone please confirm whether the issue persists with the new version?

Thank you. We just tried changing an Infura API configuration. We're not sure how long it will take to have an effect, but we may see some improvements in the...