Mark

Results 36 comments of Mark

@FoxDaxian i used https://github.com/wylieconlon/jsonrpc-ws-proxy and, with a couple of configuration bits inside of the client.ts, had it up and running (syntax, suggestions, etc). Only syntax highlighting to go. the workspaceFolder...

Hey, if this is still occurring, I posted my solution here: https://github.com/microsoft/monaco-editor/issues/1482

@stesie when you say without v8js, do you mean just vanilla PHP? ```php

`v8js_free_storage` never gets called for my example when the `var a = ` is given a closure constructed in PHP. Removing that line, or changing the return type of 'getthing'...

and a bit more digging.... i changed my `getthing()` method to return a closure: ```php return Closure::fromCallable(function() { }); ``` but that had the same result. Poking around in the...

@stesie if v8js_free_storage is only called when the main V8Js instance is GC’d but there are closures bound to it out in the ether, then the code within that cleans...

Extra: it’s not just closures. A regular object that holds a reference to V8Js will also leak.

@stesie regular PR via here, perhaps? https://github.com/php/doc-en/tree/master/reference/v8js

@stesie is this literally as simple as adding (in v8js_methods.cc): ```cpp v8js_throw_script_exception(c->isolate, &try_catch); ``` in place of: ```cpp info.GetReturnValue().Set(isolate->ThrowException(V8JS_SYM("Module script compile failed"))); ``` to somewhat match the one found in...

@usback this might be entirely useless for you, but having had similar errors, make sure you're starting from a clean slate when you're building for different versions of libv8, php,...