Kenshi

Default protocol is inconsistent with Node's.

2

If not specified, http-browserify sets the protocol to `window.location.protocol`. This differs from the behavior of Node (see https://nodejs.org/api/http.html#http_http_request_options_callback ). I assume the reasoning was to make https requests if the...

ByteBuffer.fromHex returns an empty buffer for non-hex characters

1

Using version 3.5.5 with nodejs v0.12.4 ``` var ByteBuffer = require('bytebuffer') var a = ByteBuffer.fromHex('vvzzkk', true, false) console.log(a); var b = ByteBuffer.fromHex('vvzzkk', true, true) console.log(b); ``` prints ``` { buffer:...

Specifying include_dirs on OSX?

2

I had to make the following change to setup.py in order to build/install imposm.parser on OSX. ``` python ext_modules=[ Extension("imposm.parser.pbf.OSMPBF", ["imposm/parser/pbf/osm.cc", "imposm/parser/pbf/osm.pb.cc"], libraries=['protobuf'], include_dirs=['/usr/local/include'] # Add include_dirs ), ], ```...

Fixes #45

hmset doesn't work without a callback function

1

hmset incorrectly exits early when there is no callback function. The existing tests use the callback to trigger an expectation, which is why I think it fell through the cracks....

timing_since measures microseconds, reports milliseconds

1

Looks like timing_since measures microseconds, which in turn calls timing() and sets the units explicitly to ms.