realbigsean

Results 83 comments of realbigsean

Let me know what you think about the implementation in #3412 > I think the implementation must be careful not to just check that the head is optimistic in one...

It's actually currently named `--builder-proposals` and has an alias to `--private-tx-proposals`

@torfbolt thanks a lot for the feedback! > For distributing I would vote for launchpad, this has the advantage that it's very easy for a user to setup as an...

Hey @jmcph4, I've left this as blocked because although we can now successfully vendor lighthouse dependencies using `cargo vendor`, this command doesn't work in our CI (https://github.com/sigp/lighthouse/pull/2076#issuecomment-784477635). But I saw...

I do plan on picking this back up! but will need to think about how we want package distribution to work post-merge

> I think we'd still distribute as a stand-alone lighthouse package. Users would need to install lighthouse plus an execution client to get a "full node". Do you have thoughts...

>But it provides no ability to override file config with cli args and requires using a syntax along the lines of lighthouse bn @argfile which is unlike what is provided...

The CLI tests are so massive for this! Caught a bunch of issues!

Script for checking out the `--help` diff between two lighthouse binaries: https://gist.github.com/realbigsean/3b1de807c938348fc0ba5d76709d2a37